[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] patch for log_enqueue in multipath-tools-0.4.4-pre11



Merged, thanks.
Good to see new eyeballs in there.

Have you spoted design flaws in the async logger ?

Regards,
cvaroqui

On lun, 2005-04-11 at 15:59 -0500, Benjamin Marzinski wrote:
> It looks to me like log_enqueue can accidentally mess up its la->tail ptr,
> if it runs out of space for the new message.
> 
> If the la->head is just past la->start, and la->tail is just before la->end,
> la->tail will get updated to be la->start, because there is no room at the
> end of the buffer for the message.  Then when it realizes that there is no
> room at the start of the buffer, la->tail will be updated to la->start - fwd
> And the next message will be written before the buffer.
> 
> This patch fixes that.
> 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]