[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] Re: [PATCH] dm: memory leak in failed table_load()



On Wed, Nov 09, 2005 at 05:07:32PM -0500, Kiyoshi Ueda wrote:
> @@ -974,6 +974,7 @@ static int table_load(struct dm_ioctl *p
>  	if (!hc) {
>  		DMWARN("device doesn't appear to be in the dev hash table.");
>  		up_write(&_hash_lock);
> +		dm_table_put(t);
>  		return -ENXIO;

Well spotted!

Added to dev patchset and will push alongside with some other stuff in a 
few days' time.
  http://www.kernel.org/pub/linux/kernel/people/agk/patches/2.6/editing/dm-ioctl-missing-put-in-table-load-error-case.patch

Alasdair
-- 
agk redhat com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]