Using the patch you had sent, which uses regcomp and regexec, policies are not effected on devices whose product ID is “OPEN-3” or “OPEN-V” or “OPEN-K” if I have the following device struct in /etc/multipath.conf.
vendor “HP “
product “OPEN “
My suggestion to changes are made in strcmp_chomp is with out applying the patch you had sent.
Date: Mon, 10 Oct 2005 14:23:22 +0200
From: Christophe Varoqui <christophe varoqui free fr>
Subject: [dm-devel] Re: DM configuration
To: dm-devel redhat com
Message-ID: <20051010122322 GA23091 free fr>
Content-Type: text/plain; charset=us-ascii
On Mon, Oct 10, 2005 at 05:19:45PM +0530, Murthy, Narasimha Doraswamy (STSD) wrote:
> The one mentioned below will be success for the regular expressions
> that matches anywhere in the string. Can we modify strcmp_chomp(...)
> in <multipath-src>/libmultipath/utils.c as below:
> # diff util.c util.c.mod
> < return(strcmp(s1,s2));
> > return(strncmp(s1,s2,strlen(s1)));
> so that both the partial string and the complete string can be compared.
I fear I don't understand your mail : Isn't the regexp solution enought ? Is it overkill ? Why modify strcmp_chomp(), as it no longer is in the find_hwe() code path ?
With the patch I posted you can specify vendor/product ids like this :
Isn't that what you asked for ?