[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [multipath-tools][PATCH] two small fixes



> >
> ok,
> btw, you forgot structs.c:alloc_path()

Oops. Sorry.
 
> > 
> > 2. The status information from path selectors that apply to paths are 
> > repeated for
> >         each path.
> > 
> > 
> Can you explain this with some example ... I fail to see the logic :/

For dmsetup status:

ess15-5320: 0 6835968 multipath 1 0 0 1 1 A 0 2 1 8:0 A 0 x 8:16 A 0 x
                                                ^

The 1 after the number of paths means the path selector will write 1 
additional piece of information
after the default output of each path. (e.g. <device> <state> <failcount> 
<something>)
The current code expects these data only once after all paths have been 
written but it has to skip
these data for every path. The round-robin slector doesn't use any data 
per path so the current
logic work but as soon as it is used you would fail to get the current 
state.

Stefan

SW Linux on zSeries Development & Services
Stefan Bader de ibm com
----------------------------------------------------------------------------------
  When all other means of communication fail, try words.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]