[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] Re: [patch 1/1] md/dm: Reduce stack usage with stacked block devices



On Mon, Jan 09, 2006 at 06:31:10PM -0800, Andrew Morton wrote:
> When stacked block devices are in-use (e.g.  md or dm), the recursive calls
> to generic_make_request can use up a lot of space, and we would rather they
> didn't.
 
I can see nothing wrong with this in principle.

For device-mapper at the moment though it's essential that, while the bio 
mappings may now get delayed, they still get processed in exactly
the same order as they were passed to generic_make_request().

My main concern is whether the timing changes implicit in this patch
will make the rare data-corrupting races in the existing snapshot code
more likely. (I'm working on a fix for these races, but the unfinished
patch is already several hundred lines long.)

It would be helpful if some people on this mailing list would test 
this patch in various scenarios and report back.

Alasdair
-- 
agk redhat com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]