[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [RFC, PATCH] dm-log.c: Work with devices with hard-sector-size > 512 bytes



On Mon, Mar 27, 2006 at 03:46:24PM -0600, Kevin Corry wrote:
> However, this necessitated a change of the disk-log version
> from 2 to 3, meaning the new code would not be compatible with any
> existing disk-logs. 

Several points:
  The patch should have no impact on existing users for whom everything
  is working OK - compatibility should be preserved.

  People who need the patch are unable to use this code yet so there's no
  need to preserve compatibility for them.

  We need to continue to support disk logs being loaded onto different
  machines/devices from where they were created.

  If there's no alternative but to take the disruptive step of changing
  the header version number (not convinced of that yet) then we should
  fix other problems with the header at the same time e.g. LOG_OFFSET
  should only be used when creating a new log, not when reading an
  existing one (ie store it in the header); version should include
  compatibility mechanism (flags and/or major/minor) etc.

Alasdair
-- 
agk redhat com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]