[dm-devel] Re: [patch 7/8] drivers: use list_move()

[Matthew Wilcox]

On Thu, Mar 30, 2006 at 04:16:12PM +0800, Akinobu Mita wrote:
>  drivers/scsi/ncr53c8xx.c                       |    3 +--

> Index: 2.6-git/drivers/scsi/ncr53c8xx.c
> ===================================================================
> --- 2.6-git.orig/drivers/scsi/ncr53c8xx.c
> +++ 2.6-git/drivers/scsi/ncr53c8xx.c
> @@ -5118,8 +5118,7 @@ static void ncr_ccb_skipped(struct ncb *
>  		cp->host_status &= ~HS_SKIPMASK;
>  		cp->start.schedule.l_paddr = 
>  			cpu_to_scr(NCB_SCRIPT_PHYS (np, select));
> -		list_del(&cp->link_ccbq);
> -		list_add_tail(&cp->link_ccbq, &lp->skip_ccbq);
> +		list_move_tail(&cp->link_ccbq, &lp->skip_ccbq);
>  		if (cp->queued) {
>  			--lp->queuedccbs;
>  		}

ACK.  Thanks!