[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 3/4] dm-userspace: fix DMU_FLAG_SYNC



From: Dan Smith <danms us ibm com>
Subject: Re: [dm-devel] [PATCH 3/4] dm-userspace: fix DMU_FLAG_SYNC
Date: Sat, 30 Sep 2006 08:50:33 -0700

> FT> Seems that DMU_FLAG_SYNC flag is always set. Is this intentional?
> 
> Yes.  We set this flag so that in endio we can decide whether or not
> to send a notification to userspace before we allow it to complete.
> Perhaps this should be named something more descriptive, like
> DELAY_COMPLETE or something like that.

My point is that the kernel module always sets DMU_FLAG_SYNC flag
regardless of user space. As the patch does, should dmu_cpy_flag be
used instead of cmu_set_flag? This enables a user-space programs to
choose the behavior.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]