[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] boolian logic bug in vgremove



Hi

In the argument checking code of vgreduce.c there are two occasions of
'&' that really should be '&&'. Patch below.

Signed-off.by: Andre Noll <maan systemlinux org>
---
Index: vgreduce.c
===================================================================
RCS file: /cvs/lvm2/LVM2/tools/vgreduce.c,v
retrieving revision 1.55
diff -u -r1.55 vgreduce.c
--- vgreduce.c	9 Jan 2007 23:14:34 -0000	1.55
+++ vgreduce.c	31 Jan 2007 15:17:01 -0000
@@ -427,13 +427,13 @@
 	int ret = 1;
 	int consistent = 1;
 
-	if (!argc & !arg_count(cmd, removemissing_ARG)) {
+	if (!argc && !arg_count(cmd, removemissing_ARG)) {
 		log_error("Please give volume group name and "
 			  "physical volume paths");
 		return EINVALID_CMD_LINE;
 	}
 
-	if (!argc & arg_count(cmd, removemissing_ARG)) {
+	if (!argc && arg_count(cmd, removemissing_ARG)) {
 		log_error("Please give volume group name");
 		return EINVALID_CMD_LINE;
 	}

Andre
-- 
The only person who always got his work done by Friday was Robinson Crusoe

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]