[dm-devel] [2.6.23 PATCH 02/18] dm: bio_list prefetch removal

Alasdair G Kergon agk at redhat.com
Wed Jul 11 20:57:01 UTC 2007


From: Alasdair G Kergon <agk at redhat.com>

Remove dubious prefetch from bio_list_for_each() macro.

Cc: Jens Axboe <jens.axboe at oracle.com>
Signed-off-by: Alasdair G Kergon <agk at redhat.com>

---
 drivers/md/dm-bio-list.h |    4 +---
 1 files changed, 1 insertion(+), 3 deletions(-)

Index: linux/drivers/md/dm-bio-list.h
===================================================================
--- linux.orig/drivers/md/dm-bio-list.h	2007-07-11 21:37:36.000000000 +0100
+++ linux/drivers/md/dm-bio-list.h	2007-07-11 21:37:37.000000000 +0100
@@ -8,7 +8,6 @@
 #define DM_BIO_LIST_H
 
 #include <linux/bio.h>
-#include <linux/prefetch.h>
 
 struct bio_list {
 	struct bio *head;
@@ -31,8 +30,7 @@ static inline void bio_list_init(struct 
 }
 
 #define bio_list_for_each(bio, bl) \
-	for (bio = (bl)->head; bio && ({ prefetch(bio->bi_next); 1; }); \
-	     bio = bio->bi_next)
+	for (bio = (bl)->head; bio; bio = bio->bi_next)
 
 static inline unsigned bio_list_size(const struct bio_list *bl)
 {




More information about the dm-devel mailing list