[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 3/3] multipath: implement controller framework for hardware handlers (fwd)



From: Hannes Reinecke <hare suse de>
diff --git a/drivers/md/dm-hw-handler.h b/drivers/md/dm-hw-handler.h
> index 9216682..6f91b55 100644
> --- a/drivers/md/dm-hw-handler.h
> +++ b/drivers/md/dm-hw-handler.h
> @@ -15,10 +15,31 @@
>  
>  struct hw_handler_type;
>  
> +#define CTLR_ID_LEN 256
> +
> +struct hw_controller {
> +	struct list_head node;
> +	struct hw_controller_type *type;
> +	unsigned char ctlr_id[CTLR_ID_LEN];
> +	struct kref kref;
> +	spinlock_t lock;
> +	struct list_head cmd_list;
> +	int submitted;
> +	void *context;
> +};
> +
> +struct hw_controller_type {
> +	char *name;
> +
> +	int (*create) (struct hw_controller *ctlr);
> +	void (*destroy) (struct hw_controller *ctlr);
> +};
> +

Would it make sense to make hw_controller_type a kobj_type?  That way,
the controller topology could be reflected in sysfs, where it can be
reached by tools such as lsscsi.

Chip

-- 
Charles M. "Chip" Coldwell
Senior Software Engineer
Red Hat, Inc
978-392-2426


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]