[dm-devel] Re: dm-ioctl on amd64 with 32bit userspace

[Guido Guenther]

Hi,
On Thu, Sep 20, 2007 at 02:24:48AM +0100, Alasdair G Kergon wrote:
> On Wed, Sep 19, 2007 at 05:26:50PM -0700, Andrew Morton wrote:
> > I don't understand why people aren't running around with their hair on fire
> > over this bug.    Is everyone running 64-bit dmsetup, or what?
>  
> 1) There probably aren't many users in a mixed 32/64 environment;
> 2) The operations triggering the problem are fairly uncommon.
> 
> It's still a surprise nobody noticed this before (with lvrename) as it looks
> like this has always been broken.
> 
> This particular patch looks inadequate though - fixes it for some people
> but breaks it for others?  Other parts of this code call alignment
Well at least it shouldn't break things for others, it just makes the
comparision a bit less strict - I agree that the code doesn't look nice
though.
Cheers,
 -- Guido