[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 2/6] block: no need to initialize rq->cmd with blk_get_request



On Fri, 25 Apr 2008 11:45:01 -0500
James Bottomley <James Bottomley HansenPartnership com> wrote:

> On Sat, 2008-04-26 at 01:23 +0900, FUJITA Tomonori wrote:
> > blk_get_request initializes rq->cmd (rq_init does) so the users don't
> > need to do that.
> > 
> > The purpose of this patch is to remove sizeof(rq->cmd) and &rq->cmd,
> > as a preparation for large command support, which changes rq->cmd from
> > the static array to a pointer. sizeof(rq->cmd) will not make sense and
> > &rq->cmd won't work.
> > 
> > Signed-off-by: FUJITA Tomonori <fujita tomonori lab ntt co jp>
> > Cc: James Bottomley <James Bottomley HansenPartnership com>
> > Cc: Alasdair G Kergon <agk redhat com>
> > Cc: Jens Axboe <jens axboe oracle com>
> > ---
> >  block/scsi_ioctl.c          |    3 ---
> >  drivers/block/pktcdvd.c     |    2 --
> >  drivers/cdrom/cdrom.c       |    1 -
> 
> These:
> 
> >  drivers/md/dm-emc.c         |    2 --
> >  drivers/md/dm-mpath-hp-sw.c |    1 -
> >  drivers/md/dm-mpath-rdac.c  |    1 -
> 
> Conflict with this set of patches:
> 
> http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-pending-2.6.git;a=summary
> 
> Which move the dm pieces to being request based.  The patch series
> hasn't had an ACK yet from Alasdair, but it would be nice if you could
> look it over and see if it needs the memsets pulling out.

Seems that it needs the memsets pulling out. For example,

[PATCH 2/7] scsi_dh: add lsi rdac device handler has:

+	memset(&rq->cmd, 0, BLK_MAX_CDB);


Do you want a patch against scsi-pending?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]