[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] Re: [PATCH] Implement barrier support for single device DM devices



On Fri, Feb 15, 2008 at 04:07:54PM +0300, Michael Tokarev wrote:
> Alasdair G Kergon wrote:
> > On Fri, Feb 15, 2008 at 01:08:21PM +0100, Andi Kleen wrote:
> >> Implement barrier support for single device DM devices
> > Thanks.  We've got some (more-invasive) dm patches in the works that
> > attempt to use flushing to emulate barriers where we can't just
> > pass them down like that.
> I wonder if it's worth the effort to try to implement this.

The decision got taken to allocate barrier bios to implement the basic
flush so dm has little choice in this matter now.  (If you're going to
implement barriers for flush, you might as well implement them more
generally.)

Maybe I should spell this out more clearly for those who weren't
tracking this block layer change:  AFAIK You cannot currently flush a
device-mapper block device without doing some jiggery-pokery.

> For example, how safe
> xfs is if barriers are not supported or turned off?  

The last time we tried xfs with dm it didn't seem to notice -EOPNOTSUPP
everywhere it should => recovery may find corruption.

Alasdair
-- 
agk redhat com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]