[dm-devel] [PATCH] dm-raid1.c: Conditionally ignore kcopyd errors depending on whether mirror handles them

Jonathan Brassow jbrassow at redhat.com
Fri Jul 25 15:18:28 UTC 2008


	brassow

dm-raid1 is setting the flag to ignore errors in kcopyd.  Now that
mirroring is capable of handling errors, it should.  So, we make
the setting of the 'ignore errors' flag conditional on whether
mirror is handling errors or not.

Signed-off-by: Jonathan Brassow <jbrassow at redhat.com>

Index: linux-2.6.26-rc8/drivers/md/dm-raid1.c
===================================================================
--- linux-2.6.26-rc8.orig/drivers/md/dm-raid1.c
+++ linux-2.6.26-rc8/drivers/md/dm-raid1.c
@@ -842,7 +842,9 @@ static int recover(struct mirror_set *ms
 	}
 
 	/* hand to kcopyd */
-	set_bit(DM_KCOPYD_IGNORE_ERROR, &flags);
+	if (!errors_handled(ms))
+		set_bit(DM_KCOPYD_IGNORE_ERROR, &flags);
+
 	r = dm_kcopyd_copy(ms->kcopyd_client, &from, ms->nr_mirrors - 1, to,
 			   flags, recovery_complete, reg);
 





More information about the dm-devel mailing list