[dm-devel] Re: [PATCH 1/9] scsi_dh: Implement common device table handling

[Chandra Seetharaman]

Great then.

Acked-by: Chandra Seetharaman <sekharan at us.ibm.com>

On Thu, 2008-06-26 at 14:45 +0200, Hannes Reinecke wrote:
> Hi Chandra,
> 
> Chandra Seetharaman wrote:
> > Other than one minor issue the code looks good (sorry for the late
> > realization on my part).
> > 
> > Issue: scsi_dh_handler_detach() references scsi_dh with no check for
> > null and scsi_dh_notifier() call it with scsi_dh == NULL. code can be
> > changed to get the device handler from sdev.
> > 
> This is fixed in patch 7/9. I thought I had rediffed them properly,
> but apparently not. Sorry for that.
> 
> Thanks for the review.
> 
> Cheers,
> 
> Hannes