[dm-devel] [PATCH] DEVICE-MAPPER: Use shorter list_splice_init() for brevity.

Robert P. J. Day rpjday at crashcourse.ca
Sun Mar 23 14:32:39 UTC 2008


Signed-off-by: Robert P. J. Day <rpjday at crashcourse.ca>

---

diff --git a/drivers/md/dm-raid1.c b/drivers/md/dm-raid1.c
index 5160587..e7c4432 100644
--- a/drivers/md/dm-raid1.c
+++ b/drivers/md/dm-raid1.c
@@ -405,24 +405,21 @@ static void rh_update_states(struct region_hash *rh)
 	write_lock_irq(&rh->hash_lock);
 	spin_lock(&rh->region_lock);
 	if (!list_empty(&rh->clean_regions)) {
-		list_splice(&rh->clean_regions, &clean);
-		INIT_LIST_HEAD(&rh->clean_regions);
+		list_splice_init(&rh->clean_regions, &clean);

 		list_for_each_entry(reg, &clean, list)
 			list_del(&reg->hash_list);
 	}

 	if (!list_empty(&rh->recovered_regions)) {
-		list_splice(&rh->recovered_regions, &recovered);
-		INIT_LIST_HEAD(&rh->recovered_regions);
+		list_splice_init(&rh->recovered_regions, &recovered);

 		list_for_each_entry (reg, &recovered, list)
 			list_del(&reg->hash_list);
 	}

 	if (!list_empty(&rh->failed_recovered_regions)) {
-		list_splice(&rh->failed_recovered_regions, &failed_recovered);
-		INIT_LIST_HEAD(&rh->failed_recovered_regions);
+		list_splice_init(&rh->failed_recovered_regions, &failed_recovered);

 		list_for_each_entry(reg, &failed_recovered, list)
 			list_del(&reg->hash_list);
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================




More information about the dm-devel mailing list