[dm-devel] Re: [PATCH 0/7] scsi_dh framework update

[Chandra Seetharaman]

Hi Hannes,

Thanks for the clean up and the new features. I have reviewed the code
but hasn't tested it. Comments follow.

BTW, checkpatch.pl generates warnings for patches 1 thru 5.

regards,

chandra
On Wed, 2008-05-14 at 16:42 +0200, Hannes Reinecke wrote:
> Hi James,
> 
> this is a repost of my patchset to update the scsi_dh infrastructure.
> 
> It's based on the current scsi-misc tree.
> 
> Main features of the patchset are:
> - Use a single callback for the notifier chain
> - Merge all device maps into a single list,
>   which will be scanned by a generic function
> - Add a sysfs attribute 'dh_state' for each sdev
> - Add a generic SPC-3 ALUA device handler
> - Update device handlers to check if the
>   device actually supports this handler.
>   When attaching manually we are able to attach
>   to basically any device, so we have to make sure
>   that the device handler is actually supported.
> - Manually attach a device when a hardware handler
>   is specified; this allows multipath to override
>   the built-in hardware table.
> 
> As per usual, comment etc are welcome.
> 
> Cheers,
> 
> Hannes