[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] Re: [PATCH 3/7] scsi_dh: add generic SPC-3 alua handler



It is a question to Jens :) 

On Thu, 2008-05-15 at 10:13 +0200, Hannes Reinecke wrote:
> Chandra Seetharaman wrote:
> > I do not know the functionality of this module. So, my comments are only
> > related to code.
> > 
> > blk_request_rq() frees up the request before it returns (in
> > blk_end_sync_rq()). So, there is no need for blk_put_request().
> > 
> Indeed. But this opens up another question:
> 
> By the time blk_execute_rq() returns, the request is already
> put back onto the queue.
> That means that I shouldn't access rq->errors any more, as
> the request might have been reused already.
> But blk_execute_rq() returns -EIO for any error, making it
> impossible to signal a proper error here.
> So how do I get the contents of rq->errors safely?
> 
> Cheers,
> 
> Hannes


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]