[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] multipath-tools/libmultipath alias.h



CVSROOT:	/cvs/dm
Module name:	multipath-tools
Branch: 	RHEL4_FC5
Changes by:	wysochanski sourceware org	2008-10-09 18:47:56

Modified files:
	libmultipath   : alias.h 

Log message:
	Fix rhbz445268: Increase bindings file lock timeout to avoid failure of user_friendly_names map
	
	Backport from upstream.
	From 29372b2edf719f30f21c610d502999fdf7d19885 Mon Sep 17 00:00:00 2001
	From: Dave Wysochanski <dwysocha redhat com>
	Date: Tue, 23 Sep 2008 13:16:38 -0400
	Subject: [PATCH] Increase bindings file lock timeout to avoid failure of user_friendly_names map.
	
	On setups with a large number of paths / multipath maps, contention for
	the advisory lock on the bindings file may take longer than 3 seconds,
	and some multipath processes may create maps based on WWID despite having
	user_friendly_names set.  Increasing the timeout is a simple fix that
	gets us a bit further.
	
	More extensive fixes might include:
	1) improving the efficiency of the critical section code
	2) use shared/read locks initially, then use exclusive/write locks only when
	it is known the bindings file needs updated

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/multipath-tools/libmultipath/alias.h.diff?cvsroot=dm&only_with_tag=RHEL4_FC5&r1=1.1&r2=1.1.2.1

--- multipath-tools/libmultipath/alias.h	2005/11/09 22:28:58	1.1
+++ multipath-tools/libmultipath/alias.h	2008/10/09 18:47:50	1.1.2.1
@@ -1,4 +1,4 @@
-#define BINDINGS_FILE_TIMEOUT 3
+#define BINDINGS_FILE_TIMEOUT 30
 #define BINDINGS_FILE_HEADER \
 "# Multipath bindings, Version : 1.0\n" \
 "# NOTE: this file is automatically maintained by the multipath program.\n" \


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]