[dm-devel] [PATCH 10/13] dm: add core functions for request-based dm

Nikanth K nikanth at gmail.com
Fri Oct 24 07:44:50 UTC 2008


On Fri, Sep 12, 2008 at 8:16 PM, Kiyoshi Ueda <k-ueda at ct.jp.nec.com> wrote:
<snip>

> +static int dm_make_request(struct request_queue *q, struct bio *bio)
> +{
> +       struct mapped_device *md = (struct mapped_device *)q->queuedata;
> +
> +       if (unlikely(bio_barrier(bio))) {
> +               bio_endio(bio, -EOPNOTSUPP);
> +               return 0;
> +       }
> +
<snip>

Why not add barrier support in the beginning itself, so that targets
can be developed with barriers in mind? At least can we make the target
to return error, instead of the core?

Thanks
Nikanth Karthikesan




More information about the dm-devel mailing list