[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] Re: [PATCH 2/9] dm snapshot: add lookup_completed_exception hook to struct exception_store



On Mon, Oct 27, 2008 at 09:07:49PM +0900, FUJITA Tomonori wrote:
> +struct dm_snap_exception *lookup_complete_exception(struct dm_snapshot *s,
> +						    chunk_t chunk)
> +{
> +	if (s->store.lookup_completed_exception)
> +		return s->store.lookup_completed_exception(&s->store, chunk);
> +	else
> +		return lookup_exception(&s->complete, chunk);
> +}

Can we have symmetry here such that lookup_completed_exception is *required* to be
defined for all snapshot types?

Alasdair
-- 
agk redhat com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]