[dm-devel] Re: [PATCH v2] expose dm-stripe target's topology I/O hints
Martin K. Petersen
martin.petersen at oracle.com
Thu Aug 27 17:26:28 UTC 2009
>>>>> "Mike" == Mike Snitzer <snitzer at redhat.com> writes:
Mike> Martin didn't expose such an interface because all existing code
Mike> (both DM and MD) does not require anything beyond a simple
Mike> assignment. I worked with Martin to establish the
Mike> blk_queue_io_min() precisely because DM needed to avoid
Mike> duplicating the block layer's logic. I think Martin stopped short
Mike> of adding a symmetric wrapper for setting io_opt because he felt
Mike> it was unnecessary.
Jens is a hardliner and refuses unused functions and wrappers in block.
Even when they are trivial/obvious/symmetric.
At the time I submitted the topology code there were no users of a
blk_limits_io_opt() call so I didn't wire it up.
If you need it now, then great. Let's add it to be consistent.
--
Martin K. Petersen Oracle Linux Engineering
More information about the dm-devel
mailing list