[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 1/2] dm-ioband: I/O bandwidth controller v1.10.0: Source code and patch



So, what needs to be reviewed?


1. General style/layout/naming cleanup.
- It's pretty good compared to a lot of patches that get sent, but there are
still a few things we can improve.

Lindent is throwing up some stuff (but remember it doesn't get things
perfect so don't make all the changes it recommends).
Remove double blank lines, plenty of unnecessary braces, "unsigned int" ->
"unsigned".  
Review the names - should a few more things get a DM_ or dm_ prefix?
Are all the names consistent and as self-explanatory as they can reasonably be?
(e.g. a variable called 'new' - new what?)


2. A high-level review.
Review the documentation and what the code does and how it does it.
- Does it make sense to add this to the kernel in this way?


3. A device-mapper review.
- Does the code fit into device-mapper correctly, using all the dm interfaces properly?


4. A detailed code review.
- Checking for correctness, fixing typos, improving messages, looking for ways
  to improve the code structure etc.


So, it needs volunteers on this list to take on aspects of that and lend their
support to the patch.

I consider items 1, 2 and 3 as blockers that must be completed satisfactorily before
I can push it upstream.  (Items 1 and 3 should be quick; 2 may take a bit
longer.)  Item 4 is of course open-ended so does not have to be finished before
it can be included.

Alasdair
-- 
agk redhat com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]