[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] [PATCH multipath-tools-0.4.7.rhel5.13 1/1] multipathd excessive path checker logging




multipathd logs a path checker message whenever state changes. But it also logs every non-changed message when verbosity is >=4 and newstate is PATH_UP or PATH_GHOST, and every non-changed message when verbosity is >= 2 and newstate is PATH_DOWN.

I believe that the message should only be logged, once, when state changes.

Signed-off-by: Charlie Brady <charlieb budge apana org au>

--- multipath-tools-0.4.7.rhel5.13/multipathd/main.c	2009-06-25 13:32:57.248455000 -0400
+++ mezzanine_patched_multipath-tools-0.4.7.rhel5.13/multipathd/main.c	2009-06-25 13:32:12.968639000 -0400
@@ -1041,7 +1041,6 @@
 					enable_group(pp);
 			}
 			else if (newstate == PATH_UP || newstate == PATH_GHOST) {
-				LOG_MSG(4, checker_message(&pp->checker));
 				/*
 				 * double the next check delay.
 				 * max at conf->max_checkint
@@ -1055,8 +1054,6 @@
 				condlog(4, "%s: delay next check %is",
 						pp->dev_t, pp->tick);
 			}
-			else if (newstate == PATH_DOWN)
-				LOG_MSG(2, checker_message(&pp->checker));

 			pp->state = newstate;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]