[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] [PATCH 1 of 1] dm table cleanup warning message



Patch name: dm-table-cleanup-warning-message.patch

Adjust warning message, since there is no dm_table_remove_device
which the message references.  I found it also helpful to get
a message about /which/ device was not dm_put_device'ed.

Signed-off-by: Jonathan Brassow <jbrassow redhat com>

Index: linux-2.6/drivers/md/dm-table.c
===================================================================
--- linux-2.6.orig/drivers/md/dm-table.c
+++ linux-2.6/drivers/md/dm-table.c
@@ -299,9 +299,11 @@ void dm_table_destroy(struct dm_table *t
 
 	/* free the device list */
 	if (t->devices.next != &t->devices) {
-		DMWARN("devices still present during destroy: "
-		       "dm_table_remove_device calls missing");
+		struct dm_dev_internal *dd;
 
+		DMWARN("dm_put_device calls missing for:");
+		list_for_each_entry(dd, &t->devices, list)
+			DMWARN(" - %s", dd->dm_dev.name);
 		free_devices(&t->devices);
 	}
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]