[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 1 of 1] dm table cleanup warning message



On Fri, Mar 20, 2009 at 10:11:18AM -0500, Jon Brassow wrote:
> +		DMWARN("dm_put_device calls missing for:");
> +		list_for_each_entry(dd, &t->devices, list)
> +			DMWARN(" - %s", dd->dm_dev.name);

The multi-line format is unnecessary there: I'm changing it.
(Think what happens if it gets intermingled with other similar-looking
multi-line output.  Each line of output should make sense in isolation.)

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]