[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] Re: [PATCH 5/9] rqdm core: simplify suspend code



On Fri, Oct 16, 2009 at 02:01:10PM +0900, Kiyoshi Ueda wrote:
> In case of suspend with "--nolockfs" but without "--noflush",
> the semantics for bio-based dm has been changed in 2.6.30 as below:
>   before 2.6.30:   I/Os submitted before the suspend invocation
>                    are flushed
>   2.6.30 or later: I/Os submitted even before the suspend invocation
>                    may not be flushed
>   (*) We had no idea whether the semantics change hurt someone.
>       (For details, see http://marc.info/?t=123994433400003&r=1&w=2)
>       But it seems no hurt since there is no complaint against 2.6.30
>       or later.

See my new reply on that thread.
 
> Since the semantics of request-based dm committed in 2.6.31-rc1
> is still old one, change it to new one by this patch.

Do you agree that after applying this patch series here, we could
reinstate 'suspend with flush' by flushing before entering the guts of
the suspend code (i.e. sending a flush to the dm device, which would be
implemented using the barrier) and then suspending (--noflush)?

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]