[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] Current shared snapshots



On Tue, Apr 20 2010 at  3:15am -0400,
Mikulas Patocka <mpatocka redhat com> wrote:

> Hi
> 
> I uploaded current shared snapshots at 
> http://people.redhat.com/mpatocka/patches/kernel/new-snapshots/r19/
> 
> Changes: cache shrinking over time, removed unused code, documentation 
> changes from you.
> 
> It doesn't contain variable renaming patches that you sent me, I think 
> it's not needed and also --- renaming variables with regular expressions 
> is dangerous. It may patch something that wasn't intended to be patched.

That is unfortunate.  I guess I won't waste my time on such cleanups in
the future.  Seriously, dismissing those changes as "not needed" is
frustrating.  Those changes really do serve to add consistency.

Your concern about using regex to do renames is valid but hardly reason
to dismiss changes.  Any unwanted change is easily caught by compiling
the result.

I really do hope you'll reconsider taking those rename changes.  I'll
refresh and re-review the changes against r19 if you're willing to
reconsider.

Mike


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]