[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 1/2 block#for-2.6.36] bio, fs: update RWA_MASK, READA and SWRITE to match the corresponding BIO_RW_* bits



(cc'ing CODA people)
Hello,

On 08/03/2010 01:21 PM, Jens Axboe wrote:
>>> Signed-off-by: Tejun Heo <tj kernel org>
>>> Reported-and-bisected-by: Vladislav Bolkhovitin <vst vlnb net>
>>> Root-caused-by: Neil Brown <neilb suse de>
>>> Cc: Jens Axobe <axboe kernel dk>
>>            ^^^^^
>>
>> (Too) common typo :-)
>>
>> Anyway, applied to for-2.6.36, thanks a lot.

Oops, I'm sorry.  Heh, it reminds me of misspelling Linus's last name
as Tolvards in a number of patches.  :-)

> Irk, we have an issue:
> 
> In file included from fs/coda/psdev.c:48:
> include/linux/coda_psdev.h:91:1: warning: "REQ_WRITE" redefined
> In file included from include/linux/fs.h:11,
>                  from include/linux/proc_fs.h:5,
>                  from fs/coda/psdev.c:31:
> include/linux/blk_types.h:154:1: warning: this is the location of the previous definition
> 
> And from include/linux/coda_psdev.h:
> 
> #define REQ_ASYNC  0x1
> #define REQ_READ   0x2
> #define REQ_WRITE  0x4
> #define REQ_ABORT  0x8
> 
> which unfortunately seem to not be under __KERNEL__ protection, but
> there are things like wait_queue_head_t structs there as well so should
> be safe to change.

Yeah, I hate it when symbols in non-core code doesn't have proper
prefix.  Prefixing CODA_ in front of those macros should do it.  Jan
Harkes, would that work for CODA?

Thanks.

-- 
tejun


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]