[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [REVISED PULL REQUEST] md updates for 2.6.36



On Mon, Aug 9, 2010 at 5:14 PM, Neil Brown <neilb suse de> wrote:
>
>  create mode 100644 lib/raid6/Makefile
>  rename {drivers/md => lib/raid6}/mktables.c (100%)
>  rename {drivers/md => lib/raid6}/raid6algos.c (100%)
>  rename {drivers/md => lib/raid6}/raid6altivec.uc (100%)
>  rename {drivers/md => lib/raid6}/raid6int.uc (100%)
>  rename {drivers/md => lib/raid6}/raid6mmx.c (100%)
>  rename {drivers/md => lib/raid6}/raid6recov.c (100%)
>  rename {drivers/md => lib/raid6}/raid6sse1.c (100%)
>  rename {drivers/md => lib/raid6}/raid6sse2.c (100%)
>  rename {drivers/md => lib/raid6}/raid6test/Makefile (100%)
>  rename {drivers/md => lib/raid6}/raid6test/test.c (100%)
>  rename {drivers/md => lib/raid6}/raid6x86.h (100%)
>  rename {drivers/md => lib/raid6}/unroll.awk (100%)

Hmm. Why "lib/raid6/raid6sse2.c" and friends? Why "raid6" twice? You
don't mean "raid6+1" (mirrored raid6 ;), so why not just remove the
second "raid6", and call it "lib/raid6/sse2.c"

But I pulled. Just in case there was some logic to the duplication.

                               Linus


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]