[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCHSET] dm: update workqueue usages



Hello,

On 12/14/2010 01:19 PM, Heinz Mauelshagen wrote:
> what's the rational behind dropping create_singlethread_workqueue() in
> favor of alloc_ordered_workqueue(...WQ_MEM_RECLAIM..) which are
> semantically identical?

create[_singlethread]_workqueue() implies WQ_MEM_RECLAIM which is
usually only necessary in the block IO path, so I'm going through all
usages and either making them use system*_wq or make use of only the
necessary features (often droppping WQ_MEM_RECLAIM), so the use of new
API basically indicates that it went through workqueue usage review
and determined to actually require a separate workqueue with the
described features.

create_*workqueue() interfaces will be deprecated once all in-kernel
users have been converted to encourage new and external code to study
and apply the new workqueue features as necessary.

For dm, this looks rather spruious as basically all workqueues in dm
need WQ_MEM_RECLAIM but as shown with the later patches, there still
are adjustments which can be made with the new API to make the
workqueues behave more efficiently.

Thanks.

-- 
tejun


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]