[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 1/6] dm-stripe: drop kstriped



On Tue, Dec 14 2010 at  6:59pm -0500,
Mike Snitzer <snitzer redhat com> wrote:

> On Sun, Dec 12 2010 at  2:10pm -0500,
> Tejun Heo <tj kernel org> wrote:
> 
> > kstriped only serves sc->kstriped_ws which runs dm_table_event().
> > This doesn't need to be executed from an ordered workqueue w/ rescuer.
> > Drop kstriped and use the system_wq instead.
>
> I'm concerned about switching to using the global system_wq and calling
> flush_scheduled_work() when resuming a DM table (calls a DM target's
> ->dtr() via dm_table_destroy in drivers/md/dm-ioctl.c:do_resume).

Ah, I just got to 4/6 and see you switched flush_scheduled_work() to:
flush_work_sync(&sc->trigger_event);

Thanks,
Mike


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]