[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH] dm-flakey target refreshed for 2.6.33



On Tue, Jan 26, 2010 at 02:20:51PM -0500, Josef Bacik wrote:
> -changed SECTOR_FORMAT to "%llu"

We also cast the parameter to 'unsigned long long' to match when displaying
sectors.

> -changed DMERR to printk (for some reason DMERR was failing and I have no idea

We moved the target name ('flakey: ') inside the macro instead of having to
write it in every message - so it needed #define DM_MSG_PREFIX.

I've made these changes and they'll appear at
http://www.kernel.org/pub/linux/kernel/people/agk/patches/2.6/editing/
next time I sync up.

> with an fs without having to do crazy things like rip out cables, so if it could
> be included in mainline that would be helpful.  Thanks,
 
Well the main thing I'm missing is a Documentation file and a patch header.
This shouldn't be hard to write - any volunteers?  Kconfig should get a few
more words too.

It still needs a review for adherence to the latest dm standards, but that should
be really quick, given how small it is.

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]