[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] [PATCH] [RFC] dm-multipath: typo, strncat instead of strncpy



strncat here doesn't seem right, strncpy should be correct!

Signed-off-by: Malahal Naineni (malahal us ibm com)

PS: But why bother correcting an entry that is going to be deleted
anyway? IMO, just deleting the strncat/strncpy line should be fine too.
Any comments???

diff -r 62c20b65bffe -r 07a9bab4a67f libmultipath/configure.c
--- a/libmultipath/configure.c	Tue Jul 20 17:08:44 2010 -0700
+++ b/libmultipath/configure.c	Tue Jul 27 17:45:48 2010 -0700
@@ -170,7 +170,7 @@ select_action (struct multipath * mpp, v
 	if (!find_mp_by_wwid(curmp, mpp->wwid)) {
 		condlog(2, "%s: remove (wwid changed)", cmpp->alias);
 		dm_flush_map(mpp->alias);
-		strncat(cmpp->wwid, mpp->wwid, WWID_SIZE);
+		strncpy(cmpp->wwid, mpp->wwid, WWID_SIZE);
 		drop_multipath(curmp, cmpp->wwid, KEEP_PATHS);
 		mpp->action = ACT_CREATE;
 		condlog(3, "%s: set ACT_CREATE (map wwid change)",


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]