[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH]md:dm.c Fix warning: statement with no effect



On 07/31/2010 12:07 PM, Alasdair G Kergon wrote:
On Sat, Jul 31, 2010 at 12:05:04PM -0700, Justin P. Mattock wrote:
haven't heard any feedback on this any ideas?
Ive noticed that having CONFIG_BLK_DEV_INTEGRITY=n I get warning messages generated by GCC(below)
    CC      drivers/md/dm.o
drivers/md/dm.c: In function 'split_bvec':
drivers/md/dm.c:1117:3: warning: statement with no effect
drivers/md/dm.c: In function 'clone_bio':
drivers/md/dm.c:1145:3: warning: statement with no effect

I'd suggest hiding it inside the .h files and not trying to scatter #ifdefs
throughout the code.

Alasdair




cool thanks.. I'll have a look and see if I can come up with something.

Justin P. Mattock


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]