[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] DM-CRYPT: Scale to multiple CPUs v3



On Sun, Oct 10 2010 at 12:41pm -0400,
Milan Broz <mbroz redhat com> wrote:

> On 10/10/2010 06:22 PM, Mike Snitzer wrote:
> > If you feel you shouldn't be doing any more to your split patches then
> > I'll review all of this closer tomorrow.
> 
> I think there was small bugfix in my patchset (some missing free in error path)
> and I change to use generic per-cpu IV struct (not ESSIV only) -
> see patch already sent here https://www.redhat.com/archives/dm-devel/2010-July/msg00118.html

Sure, but Andi's v3 was adjusted with "Mark per CPU crypto work queues
as CPU intensive."  Do your split patches do that?  I haven't looked at
the actual changes closely yet, just patch headers...
 
> Others are just small code shuffle changes (which I know agk is doing to all patches;-)

If this area is being actively changed behind the scenes then it is
pointless to try to make sense of this now.  As you said, Alasdair needs
to delegate and remove any doubt about where this patchset stands.

> I'll send patch on top of Andi's v3 if it helps something. (When back to my devel machine).

That'll be helpful (I'm sure Andi is interested).  In addition, updating
your split patches like I suggested in my previous mail would be great
too:
1) combine patch 1 and 2 so result bisect safe
2) fold Andi's v3 changes into the appropriate patch(es) of your split
   patchset

In the end I'd expect your (3?) split patches to be functionally
identical to Andi's v3 patch (only differences being the missing free
fix and your using per-cpu of a more generic IV struct).

So expressing your differences as a follow-on patch ontop of Andi's v3
patch would be great.  If Andi agrees with those changes then we can use
your split patches for the final commit sequence.

All patches would have both Andi's and your Signed-off-by.

Thanks,
Mike


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]