[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] convert dm-thin to use dm-bufio

On Fri, Aug 19 2011 at 11:37am -0400,
Joe Thornber <thornber redhat com> wrote:

> On Fri, Aug 19, 2011 at 09:31:56AM -0400, Mikulas Patocka wrote:
> > On Fri, 19 Aug 2011, Mike Snitzer wrote:
> > > -struct dm_block;
> > > +#define dm_block		dm_buffer
> > > +#define dm_block_manager	dm_bufio_client
> > > 
> > > But I think it'd be best, in the long run, to have a follow-on patch
> > > that does away with the aliases and just use the bufio structs
> > > throughout the code.  Anyway, don't need to worry about this now.  But
> > > what you've done is hack that should probably be cleaned up.
> > 
> > This way, it's easy to swap the original block manager and dm-bufio.
> > 
> > If I changed the names throughout the whole dm-thinp code, it would 
> > conflict with any changes Joe may do.
> I agree with Mikulas here.

It could be that we're all in agreement here.

In the near term it makes no sense to have the structure name churn
given the merge of bufio will be disruptive enough as it is.

I tried to convey as much above with: "Anyway, don't need to worry about
this now."

But if thinp is to be the first consumer of bufio (a substantial chunk
of code in its own right) then it stands to reason we should have thinp
act as the reference for how other targets should consume it.

So all I was suggesting is that once thinp is converted to bufio, and
there is confidence in the result, it should be updated to not have the
intermediate structure aliases that helped ease the conversion.

If what you're saying is thinp should always use the structure aliases
then I guess we'll just disagree and that'll be the end of it.  All I
can do is say my peace.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]