[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 1/6] dm-stripe: drop kstriped



Hello,

On Fri, Jan 07, 2011 at 11:02:31PM +0000, Alasdair G Kergon wrote:
> On Tue, Dec 14, 2010 at 08:34:58PM -0500, Mike Snitzer wrote:
> > On Tue, Dec 14 2010 at  6:59pm -0500,
> > Mike Snitzer <snitzer redhat com> wrote:
> > > I'm concerned about switching to using the global system_wq and calling
> > > flush_scheduled_work() when resuming a DM table (calls a DM target's
> > > ->dtr() via dm_table_destroy in drivers/md/dm-ioctl.c:do_resume).
>  
> Absolutely.
> 
> I'm not taking patch 1 in its current form - it introduces a problem
> that was not present before.  Probably part of patch 4 needs moving
> into patch 1.

I can just combine 1 and 4 then or reorder them such that
flush_work_sync() conversion happens first and then the dedicated wq
is dropped.  Which one would you prefer?

Thanks.

-- 
tejun


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]