[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH] dm-kcopyd/dm-snap: Don't read the origin on full chunk write



On 06/20/2011 10:09 AM, Joe Thornber wrote:
> On Fri, Jun 17, 2011 at 08:32:36AM -0400, Mikulas Patocka wrote:
>> This optimizes full chunk writes for snapshots.
>>
>> Note that there is a performance bug in device mapper that it doesn't ever 
>> send bios larger than 4k to snapshots. So this patch optimizes only 4k 
>> chunk sizes. Once the 4k limit will be removed from device mapper, this 
>> patch could optimize any chunk size.
> 
> Nack.  If you don't need to copy, don't send it to kcopyd.

I think that 4k limitation was removed almost from all the DM code
by introducing merge fn concept. Snapshots seems to be the last area...
(IMHO it was just simplification not bug - bio of page size (4k)
is always allowed so you do not need to solve bio split).

So there is another place where this restriction should be removed.

Anyway, I would like to use kcopyd later for crypt (online reencryption)
so any optimisation is welcome.

For the nack - I do not get it.
Joe, please can you explain the reasons?

Milan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]