[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH] DM RAID: do not print rebuilds in table line



On Mon, May 23, 2011 at 02:54:51PM -0500, Jon Brassow wrote:
> DM RAID table status should not include rebuild parameters.

Please could you give an example of a sequence of actual 'dmsetup table' +
'dmsetup status' lines after this change?  (Including reloads during and after
rebuild.)

Please update the documentation file too to mention the asymmetry, if some 
parameter is now input-only.

+ Performing a 'dmsetup table' should display the CTR table used to
+ construct the mapping (with possible reordering of optional
+ parameters).

BTW LVM2 is likely to rely on the order being preserved i.e. it must supply
them to the kernel in the order it is known to print them.  (Remember that the
'table' line gets compared as an unparsed string in userspace.)  Also update it
to say what it does rather than what it 'should' do:)

(We'll increment the API version too of course in the patch.)

Thanks,
Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]