[dm-devel] multipath-tools/path_priority pp_alua/rtpg.c p ...

[Benjamin Marzinski]

On Thu, Nov 03, 2011 at 11:04:18PM +0100, Christophe Varoqui wrote:
> On jeu., 2011-11-03 at 16:58 -0500, Benjamin Marzinski wrote:
> > On Wed, Nov 02, 2011 at 10:51:50PM +0100, Christophe Varoqui wrote:
> > > > --- multipath-tools/path_priority/pp_alua/rtpg.c	2009/08/18 21:12:02	1.3.2.5
> > > > +++ multipath-tools/path_priority/pp_alua/rtpg.c	2011/10/24 13:41:32	1.3.2.6
> > > > @@ -29,7 +29,7 @@
> > > >  #include "rtpg.h"
> > > >  
> > > >  #define SENSE_BUFF_LEN  32
> > > > -#define DEF_TIMEOUT     300000
> > > > +#define DEF_TIMEOUT     60000
> > > >  
> > > 
> > > Do you want that part merged into upstream's alua prioritizer shared
> > > object ?
> > 
> > In the RHEL5 code, this is a seperate callout program.  Upstream it
> > would be better if we could make this configurable via multipath.conf,
> > like the checker timeouts.
> > 
> Sure, but you did not implement that in the callout either. Is the 60s
> timeout value controversial ? Is that change a worthy quick-fix ?

Sure.  We've had a number of complaints about how long multipath can get
stuck in some corner cases.  This was one that caused some problems, so
I'd be happy to see the default changed.

-Ben

> 
> Regards,
> -- 
> Christophe Varoqui
> OpenSVC - Tools to scale
> http://www.opensvc.com/