[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] Error when compiling drivers/md/dm-bufio.c




On Mon, 7 Nov 2011, Linus Torvalds wrote:

> On Mon, Nov 7, 2011 at 7:36 AM, Mikulas Patocka <mpatocka redhat com> wrote:
> >
> > Yes, apply this patch:
> >
> > dm-bufio: Include <linux/module.h>
> 
> Actually, is just <linux/export.h> sufficient?
> 
> It's much better to use just export.h if you have the choice - lots of
> code doesn't need the whole module thing that brings in just about all
> the headers in the whole kernel (ok, not quite, but still..)
> 
> That was kind of the whole point of the split.
> 
>                   Linus

No, with <linux/export.h> included, it fails when compiling 
"module_param_named" macro.

Mikulas


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]