[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 2/2] blk-flush: fix invalid BUG_ON in blk_insert_flush



On Wed, Oct 12, 2011 at 05:22:42PM -0400, Jeff Moyer wrote:
> A user reported a regression due to commit
> 4853abaae7e4a2af938115ce9071ef8684fb7af4 (block: fix flush
> machinery for stacking drivers with differring flush flags).
> Part of the problem is that blk_insert_flush required a
> single bio be attached to the request.  In reality, having
> no attached bio is also a valid case, as can be observed with
> an empty flush.
> 
> [1] http://www.redhat.com/archives/dm-devel/2011-September/msg00154.html
> 
> Reported-by: Christophe Saout <christophe saout de>
> Signed-off-by: Jeff Moyer <jmoyer redhat com
> Signed-off-by: Jeff Moyer <jmoyer redhat com>

Duplicate SOB's and missing space after '/*' in the comment.  Other
than that,

 Acked-by: Tejun Heo <tj kernel org>

Thanks.

-- 
tejun


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]