[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH] multipath: strdup multipath alias, so that it isn't deleted.



On Thu, Sep 01, 2011 at 08:55:18AM +0200, Christophe Varoqui wrote:
> On mer., 2011-08-31 at 21:45 -0500, Benjamin Marzinski wrote:
> > When a multipath device is added to multipathd with ev_add_map(),
> > > the alias is not duplicated, and is freed immediately after
> > ev_add_map()
> > > returns, causing a memory error. This patch corrects that.
> > > 
> Merged.
> 
> Do you think the "mpp->alias = NULL" is still necessary in the following
> setup_multipath() error code path ? alias is set to NULL by
> free_multipath() these days ...
> 

Yeah, that looks like it can safely go.

-Ben

> >       if (setup_multipath(vecs, mpp)) {
> >               mpp->alias = NULL;                <========


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]