[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] [PATCH 0 of 2] dm-raid: Bug fixes


I have 3 bugs that I've been working on.  Two I have fixed and one I
have not, but have a question.

The first patch (dm-raid-set-recovery-flags-on-resume) addresses the
fact that some recovery flags are altered during suspend, but not
corrected upon resume.  I'm wondering if you think these flags would be
better pushed into 'mddev_resume' rather that being altered in

The second patch (dm-raid-record-and-handle-missing-devices) adds code
to address the case where the user specifies particular array positions
as missing.  I don't have any significant questions about this patch.

The 3rd issue I am seeing concerns how 'suspend' happens.  Suspend
should flush all outstanding I/O and quiesce.  When I look at the code,
I feel it should be doing this.  ('md_stop_writes' is called and
followed-up by a call to 'mddev_suspend', which quiesces the
personality.)  However, if I create a RAID1 device, suspend it, and then
detach one of the legs, it does not show the changes written immediately
before the suspend.  If I issue a 'sync', then the changes do show-up.
I confused as to why the suspend process doesn't seem to be pushing out
the writes that have been issued.  Any ideas?

Thanks, (the first two patches follow)

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]