[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] basic cache policy module fix [was: Re: Another cache target]



On Thu, Dec 20, 2012 at 08:24:59AM -0500, Mike Snitzer wrote:
> On Thu, Dec 20 2012 at  7:57am -0500,
> Heinz Mauelshagen <heinzm redhat com> wrote:
> 
> > Darrick,
> > 
> > thanks for testing.
> > 
> > Bug's a superfluous increment of the number of allocated cache
> > blocks in dm-cache-policy-basic:load_mappings().
> > 
> > Patch is attached and on my git github com:lvmguy/linux-2.6, branch
> > dm-devel-cache.
> 
> FYI, I merged the fix into my dm-devel-cache too.

kbuild had this to say:
drivers/md/dm-cache-policy-basic.c: In function ‘basic_map’:
drivers/md/dm-cache-policy-basic.c:1252:39: warning: ‘tqe’ may be used uninitialized in this function [-Wuninitialized]
drivers/md/dm-cache-policy-basic.c:1271:28: note: ‘tqe’ was declared here

I _think_ it's actually ok, but I'm not 100% sure.

Otherwise it seems to have passed the remove/recreate test.  I'll keep pounding
on it.

--D
> 
> --
> dm-devel mailing list
> dm-devel redhat com
> https://www.redhat.com/mailman/listinfo/dm-devel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]