[dm-devel] [RFC PATCH] block: all callers should check blkdev_issue_flush's return
Christoph Hellwig
hch at infradead.org
Tue Jun 26 15:51:15 UTC 2012
On Tue, Jun 26, 2012 at 11:27:25AM -0400, Mike Snitzer wrote:
> It is concerning that a FLUSH may fail but the blkdev_issue_flush
> callers assume it will always succeed.
>
> Each blkdev_issue_flush caller should come to terms with the reality
> that a FLUSH may fail -- the file_operations' .fsync methods in
> particular. nilfs2 is the only filesystem that checks
> blkdev_issue_flush's return.
Good spot, but it would be way better if you actually provided patches
to fix this instead of just adding more compiler warnings.
More information about the dm-devel
mailing list