[dm-devel] [PATCH 04/13] block: Add bio_clone_kmalloc()
Tejun Heo
tj at kernel.org
Fri May 18 16:09:03 UTC 2012
On Thu, May 17, 2012 at 10:59:51PM -0400, koverstreet at google.com wrote:
> @@ -729,7 +729,7 @@ static struct bio *bio_chain_clone(struct bio **old, struct bio **next,
> }
>
> while (old_chain && (total < len)) {
> - tmp = bio_kmalloc(gfpmask, old_chain->bi_max_vecs);
> + tmp = bio_clone_kmalloc(old_chain, gfpmask);
> if (!tmp)
> goto err_out;
>
> @@ -751,13 +751,9 @@ static struct bio *bio_chain_clone(struct bio **old, struct bio **next,
> if (!bp)
> goto err_out;
>
> - __bio_clone(tmp, &bp->bio1);
> -
This effectively swaps the order of bio_split() and __bio_clone(). Is
that safe? Also, please cc the maintainer.
Thanks.
--
tejun
More information about the dm-devel
mailing list