[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] [PATCH] fix segfault when lvm.conf is truncated.



When /etc/lvm/lvm.conf is truncated at the first '"' of a line, all LVM
utilities crash with a segfault.

The segfault only seems to occur if the last character is the first '"'
(double quote) of a line. If you truncate it at any other point, lvm detects the
error and report parse error

lvm.conf ends like this.

root#hexdump -C lvm.conf|tail
00000220  69 72 20 3d 20 22 2f 64  65 76 22 0a 0a 0a 20 20  |ir = "/dev"...  |
00000230  20 20 23 20 41 6e 20 61  72 72 61 79 20 6f 66 20  |  # An array of |
00000240  64 69 72 65 63 74 6f 72  69 65 73 20 74 68 61 74  |directories that|
00000250  20 63 6f 6e 74 61 69 6e  20 74 68 65 20 64 65 76  | contain the dev|
00000260  69 63 65 20 6e 6f 64 65  73 20 79 6f 75 20 77 69  |ice nodes you wi|
00000270  73 68 0a 20 20 20 20 23  20 74 6f 20 75 73 65 20  |sh.    # to use |
00000280  77 69 74 68 20 4c 56 4d  32 2e 0a 20 20 20 20 73  |with LVM2..  s|
00000290  63 61 6e 20 3d 20 5b 20  22 2f 78 22 2c 0a 20 20  |can = [ "/x",.  |
000002a0  20 20 20 20 20 20 20 20  20 20 20 22              | "|

The fix is check p->tb and p->te in function _dup_tok. If in
this situation, the len would be less than zero.

Signed-off-by: dongmao zhang <dmzhang suse com>
---
 libdm/libdm-config.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/libdm/libdm-config.c b/libdm/libdm-config.c
index c19f51d..167f66a 100644
--- a/libdm/libdm-config.c
+++ b/libdm/libdm-config.c
@@ -675,7 +675,12 @@ static struct dm_config_node *_create_node(struct dm_pool *mem)
 
 static char *_dup_tok(struct parser *p)
 {
-	size_t len = p->te - p->tb;
+	int len;
+	if ((len = p->te - p->tb) < 0) {
+			log_error("Parse error at byte %" PRIptrdiff_t " (line %d)",
+									p->tb - p->fb + 1, p->line);
+		return 0;
+	}
 	char *str = dm_pool_alloc(p->mem, len + 1);
 	if (!str) {
 		log_error("Failed to duplicate token.");
-- 
1.7.3.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]